Repository navigation
Test the targeting cache round trip through real SharedPreferences - #59
Merged
Merged
Conversation
LocalStorageTest mocks SharedPreferences and JSONObject, so it couldn't catch Gson writing JSONObject internals into the cache (fixed in #58). These Robolectric tests cache a parsed targeting response, read it back through a new LocalStorage instance, and check that targetingData keeps its nested objects, arrays and number types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antoinehakim-optable
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LocalStorageTestmocks SharedPreferences andJSONObject, so it couldn't catch Gson writingJSONObjectinternals into the targeting cache, the bug fixed in #58.What Changed
LocalStorageTargetingCacheTest, two Robolectric tests that cache a parsed targeting response, read it back through a newLocalStorageinstance (as after an app restart), and check thattargetingDatakeeps its nested objects, arrays and number types.